monolith

public

Star0

Fork 0

Watch0

197 commits 1 branch 0 tags 0 releases1.5 MiB

Commit `f0e45b059808`

tarball

atagen <boss@atagen.co>2026-10-19 07:56 UTC

3 files changed+10-2

render-vk: report sample-only dmabuf imports as unreadable

can_read_texture returned true for any imported dmabuf, but SAMPLE_USAGE has no TRANSFER_SRC so copy_texture would copy from an image the driver never allowed as a source. ImageInner now records its usage.

Modified file: crates/render-vk/src/dmabuf.rs+1

@@ -269,6 +269,7 @@ pub(crate) fn import(

269269 format.code,

270270 size.0,

271271 size.1,

272+ usage,

272273 true,

273274 )

274275 }

Modified file: crates/render-vk/src/image.rs+4 additions−1 deletions@@ -25,6 +25,7 @@ pub(crate) struct ImageInner {
     pub format: vk::Format,
     pub width: u32,
     pub height: u32,
+    pub usage: vk::ImageUsageFlags,
     pub layout: Mutex<vk::ImageLayout>,
     /// Shared with other devices or processes through a dmabuf. Every use
     /// acquires the image from the foreign queue family and releases it after.
@@ -117,7 +118,7 @@ impl ImageInner {
             Memory::Imported(m) => (*m, 0),
         };
         Self::finish(
-            shared, image, memory, mem, offset, fourcc, width, height, false,
+            shared, image, memory, mem, offset, fourcc, width, height, usage, false,
         )
     }
 
@@ -133,6 +134,7 @@ impl ImageInner {
         fourcc: Fourcc,
         width: u32,
         height: u32,
+        usage: vk::ImageUsageFlags,
         external: bool,
     ) -> Result<Arc<Self>, Error> {
         let fmt = vk_format(fourcc).ok_or(Error::UnsupportedFormat(fourcc))?;
@@ -146,6 +148,7 @@ impl ImageInner {
             format: fmt.format,
             width,
             height,
+            usage,
             layout: Mutex::new(if external {
                 vk::ImageLayout::GENERAL
             } else {

Modified file: crates/render-vk/src/renderer/mod.rs+5 additions−1 deletions@@ -1018,7 +1018,11 @@ impl ExportMem for VulkanRenderer {
     }
 
     fn can_read_texture(&mut self, texture: &VulkanTexture) -> Result<bool, Error> {
-        Ok(texture.0.external || texture.0.layout() != vk::ImageLayout::UNDEFINED)
+        let image = &texture.0;
+        let written = image.external
+            || image.layout() != vk::ImageLayout::UNDEFINED
+            || self.uploads.iter().any(|u| Arc::ptr_eq(&u.image, image));
+        Ok(written && image.usage.contains(vk::ImageUsageFlags::TRANSFER_SRC))
     }
 
     fn map_texture<'a>(&mut self, mapping: &'a VulkanMapping) -> Result<&'a [u8], Error> {

monolith

Commit f0e45b059808

Commit `f0e45b059808`