monolith

public

Star0

Fork 0

Watch0

217 commits 1 branch 0 tags 0 releases1.5 MiB

Commit `7e9270240c46`

tarball

atagen <boss@atagen.co>2026-10-19 08:38 UTC

1 file changed+8-3

commit: stage whole shm buffers under a viewport

Surface damage only equals buffer damage when the surface has no scale, transform or viewport, and stage_shm checked the first two. A viewport with a destination size left the staged copy short of what the surface damage covered.

Modified file: crates/monolith/src/commit.rs+8 additions−3 deletions@@ -17,6 +17,7 @@ use smithay::wayland::dmabuf::{
 };
 use smithay::wayland::drm_syncobj::{DrmSyncobjCachedState, DrmSyncobjHandler, DrmSyncobjState};
 use smithay::wayland::shm::{ShmHandler, ShmState, with_buffer_contents};
+use smithay::wayland::viewporter::ViewportCachedState;
 
 impl CompositorHandler for State {
     fn compositor_state(&mut self) -> &mut CompositorState {
@@ -199,8 +200,8 @@ fn hold_until_readable(state: &mut State, surface: &WlSurface) {
 
 /// Copies a committed shm buffer's damage on the worker, holding the commit
 /// until it is staged. Surface damage equals buffer damage at scale 1 with no
-/// transform, otherwise the whole buffer is staged so it covers whatever the
-/// import uploads.
+/// transform and no viewport, otherwise the whole buffer is staged so it covers
+/// whatever the import uploads.
 fn stage_shm(state: &mut State, surface: &WlSurface) {
     let job = with_states(surface, |s| {
         let mut cached = s.cached_state.get::<SurfaceAttributes>();
@@ -211,7 +212,11 @@ fn stage_shm(state: &mut State, surface: &WlSurface) {
         if get_dmabuf(buffer).is_ok() {
             return None;
         }
-        let plain = attrs.buffer_scale == 1 && attrs.buffer_transform == Transform::Normal.into();
+        let mut viewport = s.cached_state.get::<ViewportCachedState>();
+        let viewported = viewport.pending().src.is_some() || viewport.pending().dst.is_some();
+        let plain = attrs.buffer_scale == 1
+            && attrs.buffer_transform == Transform::Normal.into()
+            && !viewported;
         let region = attrs
             .damage
             .iter()

monolith

Commit 7e9270240c46

Commit `7e9270240c46`