monolith

public

Star0

Fork 0

Watch0

294 commits 1 branch 0 tags 0 releases1.5 MiB

Commit `0dfd45c37ecb`

tarball

atagen <boss@atagen.co>2026-10-19 10:50 UTC

2 files changed+22-5

xdg: tile windows whose size cap is larger than the output

floats() floated every toplevel with a maximum size, including clients that declare an effectively unbounded one. A cap now only floats a window when it is smaller than the whole usable area, the largest tile the window could be given.

Modified file: crates/monolith/src/windows.rs+15 additions−2 deletions@@ -47,7 +47,11 @@ impl State {
                 f64::from(r.size.h),
             )
         });
-        let auto = float.is_some() || window.toplevel().is_some_and(crate::xdg::floats);
+        let room = self.room(output);
+        let auto = float.is_some()
+            || window
+                .toplevel()
+                .is_some_and(|t| crate::xdg::floats(t, room));
         let floating = rule.floating.unwrap_or(auto);
         let id = self
             .wm
@@ -85,6 +89,14 @@ impl State {
         self.apply_layout();
     }
 
+    /// The size of the largest tile a window on `output`, or the active one,
+    /// could get.
+    fn room(&self, output: Option<OutputId>) -> Option<(f64, f64)> {
+        let layout = &self.wm.layout;
+        let usable = layout.output(output.or(layout.active_output())?)?.usable();
+        Some((usable.w, usable.h))
+    }
+
     /// Where a transient of `parent` belongs, which is where its parent is.
     /// A scratchpad or sticky parent has no tag of its own to follow.
     fn parent_context(&self, parent: Option<WindowId>) -> Option<(Option<OutputId>, TagId)> {
@@ -250,11 +262,12 @@ impl State {
     /// or fixed-size. At its first buffer it is still held on its seed, so it
     /// never shows tiled.
     pub(crate) fn float_if_hinted(&mut self, id: WindowId) -> bool {
+        let room = self.room(self.wm.layout.window(id).and_then(|w| w.output));
         let hinted = self
             .wm
             .window(id)
             .and_then(|w| w.toplevel())
-            .is_some_and(crate::xdg::floats);
+            .is_some_and(|t| crate::xdg::floats(t, room));
         let tiled = self
             .wm
             .layout

Modified file: crates/monolith/src/xdg.rs+7 additions−3 deletions@@ -19,10 +19,14 @@ use smithay::wayland::shell::xdg::{
 };
 use smithay::wayland::xdg_foreign::{XdgForeignHandler, XdgForeignState};
 
-/// Dialogs, and windows that cap their size and so could never fill a tile.
-pub fn floats(toplevel: &ToplevelSurface) -> bool {
+/// Dialogs, and windows that cap their size below `room`, the largest tile they
+/// could be given, and so could never fill it.
+pub fn floats(toplevel: &ToplevelSurface, room: Option<(f64, f64)>) -> bool {
     let (_, max) = size_hints(toplevel);
-    is_dialog(toplevel) || (max.w > 0 && max.h > 0)
+    let capped = max.w > 0
+        && max.h > 0
+        && room.is_none_or(|(w, h)| f64::from(max.w) < w || f64::from(max.h) < h);
+    is_dialog(toplevel) || capped
 }
 
 /// A toplevel with a parent, whether set through xdg_shell or xdg-foreign, or

monolith

Commit 0dfd45c37ecb

Commit `0dfd45c37ecb`