96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 1 | use std::time::Duration; |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 2 | |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 3 | use macltok::{ |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 4 | Command, CommandErrorKind, CommandKind, Engine, EngineConfig, Event, LifecycleCommand, |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 5 | MediaCommand, MediaSize, MessageContent, RoomCommand, TimelineCommand, TimelineDiff, |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 6 | TimelineItem, |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 7 | }; |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 8 | use matrix_sdk::{ |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 9 | ruma::{api::client::sync::sync_events::v5, mxc_uri, room_id}, |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 10 | test_utils::mocks::MatrixMockServer, |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 11 | }; |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 12 | use matrix_sdk_test::{ALICE, JoinedRoomBuilder, event_factory::EventFactory}; |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 13 | use wiremock::ResponseTemplate; |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 14 | |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 15 | #[tokio::test] |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 16 | async fn delayed_media_fetch_does_not_block_timeline_command() { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 17 | let server = MatrixMockServer::new().await; |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 18 | server |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 19 | .mock_sliding_sync() |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 20 | .ok(v5::Response::new("1".to_owned())) |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 21 | .mount() |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 22 | .await; |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 23 | let client = server.client_builder().build().await; |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 24 | let sync_client = client.clone(); |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 25 | let room_id = room_id!("!nonblocking:localhost"); |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 26 | server.mock_room_state_encryption().plain().mount().await; |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 27 | server.sync_joined_room(&client, room_id).await; |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 28 | let config = EngineConfig::default().with_initial_history_limit(0); |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 29 | let (engine, handle, mut events) = Engine::from_client(client, config).await.unwrap(); |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 30 | let running = tokio::spawn(engine.run()); |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 31 | |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 32 | handle |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 33 | .send(Command::Room(RoomCommand::Open(room_id.to_owned()))) |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 34 | .await |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 35 | .unwrap(); |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 36 | receive_until( |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 37 | &mut events, |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 38 | |event| matches!(event, Event::TimelineReset { timeline_id: reset, .. } if reset.room_id() == room_id), |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 39 | ) |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 40 | .await; |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 41 | |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 42 | server |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 43 | .sync_room( |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 44 | &sync_client, |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 45 | JoinedRoomBuilder::new(room_id).add_timeline_event( |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 46 | EventFactory::new() |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 47 | .image( |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 48 | "image.jpg".into(), |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 49 | mxc_uri!("mxc://localhost/image").to_owned(), |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 50 | ) |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 51 | .sender(&ALICE), |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 52 | ), |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 53 | ) |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 54 | .await; |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 55 | let media_event = receive_until(&mut events, |event| { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 56 | event_messages(event).any(|message| message.media.is_some()) |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 57 | }) |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 58 | .await; |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 59 | let media_id = event_messages(&media_event) |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 60 | .find_map(|message| message.media.as_ref().map(|media| media.id.clone())) |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 61 | .unwrap(); |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 62 | |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 63 | let delayed_image = || { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 64 | ResponseTemplate::new(200) |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 65 | .set_body_raw(b"binaryjpegfullimagedata", "image/jpeg") |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 66 | .set_delay(Duration::from_millis(500)) |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 67 | }; |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 68 | server |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 69 | .mock_media_download() |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 70 | .respond_with(delayed_image()) |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 71 | .mount() |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 72 | .await; |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 73 | server |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 74 | .mock_authed_media_download() |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 75 | .respond_with(delayed_image()) |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 76 | .mount() |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 77 | .await; |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 78 | |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 79 | let media_command_id = handle |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 80 | .send(Command::Media(MediaCommand::Fetch { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 81 | id: media_id.clone(), |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 82 | size: MediaSize::Full, |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 83 | })) |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 84 | .await |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 85 | .unwrap(); |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 86 | wait_for_media_request(&server).await; |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 87 | let timeline_command_id = handle |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 88 | .send(Command::Timeline(TimelineCommand::Send { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 89 | timeline_id: room_id.to_owned().into(), |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 90 | content: MessageContent::text(String::new()), |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 91 | })) |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 92 | .await |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 93 | .unwrap(); |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 94 | |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 95 | tokio::time::timeout(Duration::from_secs(2), async { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 96 | loop { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 97 | match events.recv().await.expect("event stream closed") { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 98 | Event::CommandFailed(failure) if failure.id == timeline_command_id => { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 99 | assert_eq!(failure.command, CommandKind::Timeline); |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 100 | assert_eq!(failure.kind, CommandErrorKind::EmptyBody); |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 101 | break; |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 102 | } |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 103 | Event::CommandSucceeded { id, .. } if id == media_command_id => { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 104 | panic!("media command completed before the timeline command") |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 105 | } |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 106 | Event::CommandFailed(failure) if failure.id == media_command_id => { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 107 | panic!("media command failed before the timeline command {failure:?}") |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 108 | } |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 109 | Event::MediaReady { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 110 | media_id: ready_id, .. |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 111 | } if ready_id == media_id => { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 112 | panic!("media became ready before the timeline command completed") |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 113 | } |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 114 | _ => {} |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 115 | } |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 116 | } |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 117 | }) |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 118 | .await |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 119 | .expect("timeline command was blocked by media fetch"); |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 120 | |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 121 | receive_until(&mut events, |event| { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 122 | matches!( |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 123 | event, |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 124 | Event::CommandSucceeded { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 125 | id, |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 126 | command: CommandKind::Media, |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 127 | } if id == &media_command_id |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 128 | ) |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 129 | }) |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 130 | .await; |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 131 | |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 132 | handle |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 133 | .send(Command::Lifecycle(LifecycleCommand::Shutdown)) |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 134 | .await |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 135 | .unwrap(); |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 136 | receive_until(&mut events, |event| matches!(event, Event::Stopped)).await; |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 137 | running.await.unwrap().unwrap(); |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 138 | } |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 139 | |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 140 | async fn wait_for_media_request(server: &MatrixMockServer) { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 141 | tokio::time::timeout(Duration::from_secs(2), async { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 142 | loop { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 143 | if server |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 144 | .received_requests() |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 145 | .await |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 146 | .unwrap() |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 147 | .iter() |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 148 | .any(|request| request.url.path().ends_with("/download/localhost/image")) |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 149 | { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 150 | break; |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 151 | } |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 152 | tokio::task::yield_now().await; |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 153 | } |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 154 | }) |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 155 | .await |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 156 | .expect("media request did not reach the homeserver"); |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 157 | } |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 158 | |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 159 | fn event_messages(event: &Event) -> std::vec::IntoIter<&macltok::TimelineMessage> { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 160 | let items = match event { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 161 | Event::TimelineReset { items, .. } => items.iter().collect::<Vec<_>>(), |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 162 | Event::TimelineChanged { diffs, .. } => { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 163 | diffs.iter().flat_map(diff_items).collect::<Vec<_>>() |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 164 | } |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 165 | _ => Vec::new(), |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 166 | }; |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 167 | items |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 168 | .into_iter() |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 169 | .filter_map(|item| match item { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 170 | TimelineItem::Message(message) => Some(message.as_ref()), |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 171 | _ => None, |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 172 | }) |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 173 | .collect::<Vec<_>>() |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 174 | .into_iter() |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 175 | } |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 176 | |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 177 | fn diff_items(diff: &TimelineDiff) -> Vec<&TimelineItem> { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 178 | match diff { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 179 | TimelineDiff::Append { values } | TimelineDiff::Reset { values } => values.iter().collect(), |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 180 | TimelineDiff::PushFront { value } |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 181 | | TimelineDiff::PushBack { value } |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 182 | | TimelineDiff::Insert { value, .. } |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 183 | | TimelineDiff::Set { value, .. } => vec![value], |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 184 | TimelineDiff::Clear |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 185 | | TimelineDiff::PopFront |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 186 | | TimelineDiff::PopBack |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 187 | | TimelineDiff::Remove { .. } |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 188 | | TimelineDiff::Truncate { .. } => Vec::new(), |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 189 | _ => Vec::new(), |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 190 | } |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 191 | } |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 192 | |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 193 | async fn receive_until( |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 194 | events: &mut macltok::EventStream, |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 195 | predicate: impl Fn(&Event) -> bool, |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 196 | ) -> Event { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 197 | tokio::time::timeout(Duration::from_secs(2), async { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 198 | while let Some(event) = events.recv().await { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 199 | if predicate(&event) { |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 200 | return event; |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 201 | } |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 202 | } |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 203 | panic!("event stream closed before the expected event") |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 204 | }) |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 205 | .await |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 206 | .expect("expected event did not arrive") |
96fdf90aacd6 | atagen | 2026-09-08 08:24 UTC | 207 | } |